Drop "nowcast-dev" run from automation workflow and configuration #229
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The deployment documentation has been updated to remove references to and instructions on building XIOS-2 and NEMO-3.6 because, as of V21-11, we no longer do the daily nowcast-dev run on salish. This keeps the docs accurate and relevant to the current project setup.
The deployment documentation has been updated to remove runs/ directory setup on skookum because, as of V21-11, we no longer do the daily nowcast-dev run on salish. This keeps the docs accurate and relevant to the current project setup.
`skookum_salish.rst` -> `skookum.rst` because, as of V21-11, we no longer do the daily nowcast-dev run on salish. So, there is no deployment setup to do on salish. This keeps the docs accurate and relevant to the current project setup.
douglatornell
added
documentation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #229 +/- ##
==========================================
- Coverage 77.74% 77.61% -0.14%
==========================================
Files 133 133
Lines 18725 18678 -47
Branches 1912 1899 -13
==========================================
- Hits 14557 14496 -61
- Misses 4110 4116 +6
- Partials 58 66 +8
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
As of V21-11, we no longer do the daily nowcast-dev run on salish.
Retained until make_plots worker is refactored to remove nowcast-dev. That refactoring needs to come after the compare_venus_ctd fig module is updated to handle the ONC API v3.
Retained because the next_workers module checks the shared storage item for all enabled hosts. So, it can't be removed for salish-nowcast until that whole stanza can be removed.
|
Successfully tested in production since 24-Jan-2024. Decided to defer cleanup of nowcast-dev figures to a future PR because it involves the change to the ONC API v3 that I am also working on presently. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As of V21-11, we no longer do the daily nowcast-dev run on salish.