Update collect_weather worker re: changes in watchdog=2.1.7
#168
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Replace the time.sleep(1) in the watchdog observer loop that collects the expected files with joining the observer thread with a 1-second timeout. We need to have a timeout on the observer thread so that the status of the expected files set gets checked, otherwise the worker never finishes because the main thread is blocked by the observer thread. I'm not really sure why this change is necessary, but it fixes the problem of the worker not collecting files after the change to the HRDPS continental grid.
watchdog and shutil.move() can now handle pathlib.Path objects.
douglatornell
added
bug
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Mostly change how the watchdog observer thread is controlled re: checking if all of the expected files have been downloaded. This fixes the problem of the worker not collecting files that arose after the change to the HRDPS continental grid.
Also drop some no longer necessary
os.fspath()calls.