Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Drop FVCOM VHFR forecast-x2 runs from automation #100

Merged
merged 1 commit into from
Apr 14, 2022

Conversation

douglatornell
Copy link
Member

They are no longer of value to stakeholders. So, dropping them makes more
compute time available when backfilling nowcast runs is necessary.

They are no longer of value to stakeholders. So, dropping them makes more
compute time available when backfilling nowcast runs is necessary.
@douglatornell douglatornell self-assigned this Apr 14, 2022
@douglatornell douglatornell added the maintenance Codebase maintenance label Apr 14, 2022
@douglatornell douglatornell added this to the v22.1 milestone Apr 14, 2022
@codecov
Copy link

codecov bot commented Apr 14, 2022

Codecov Report

Merging #100 (015579e) into main (54e2eab) will decrease coverage by 0.05%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##             main     #100      +/-   ##
==========================================
- Coverage   73.00%   72.95%   -0.06%     
==========================================
  Files         122      122              
  Lines       16068    16039      -29     
  Branches     1308     1306       -2     
==========================================
- Hits        11731    11701      -30     
  Misses       4287     4287              
- Partials       50       51       +1     
Flag Coverage Δ
unittests 72.95% <100.00%> (-0.06%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
tests/test_next_workers.py 99.71% <ø> (-0.01%) ⬇️
tests/workers/test_download_fvcom_results.py 100.00% <ø> (ø)
tests/workers/test_make_fvcom_atmos_forcing.py 100.00% <ø> (ø)
tests/workers/test_make_fvcom_boundary.py 100.00% <ø> (ø)
tests/workers/test_make_fvcom_rivers_forcing.py 100.00% <ø> (ø)
tests/workers/test_make_plots.py 98.82% <ø> (ø)
tests/workers/test_ping_erddap.py 100.00% <ø> (ø)
tests/workers/test_run_fvcom.py 100.00% <ø> (ø)
tests/workers/test_upload_fvcom_atmos_forcing.py 100.00% <ø> (ø)
tests/workers/test_watch_fvcom.py 100.00% <ø> (ø)
... and 3 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 54e2eab...015579e. Read the comment docs.

@douglatornell douglatornell merged commit cecda06 into main Apr 14, 2022
@douglatornell douglatornell deleted the drop-forecast-x2 branch April 14, 2022 17:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
maintenance Codebase maintenance
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant