Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add ability to use data to read from file with instance:export #183

Merged
merged 5 commits into from
May 26, 2021

Conversation

al-haras
Copy link
Contributor

Adds the ability to use either a file or type json to be parsed for instance:export

Potential solution for #144

@al-haras al-haras closed this Oct 30, 2020
@al-haras al-haras reopened this Oct 30, 2020
@tobiaslohr tobiaslohr self-requested a review November 4, 2020 15:24
@tobiaslohr
Copy link
Contributor

hi @al-haras , thanks a lot for your contribution. Can you please adjust the description of the command to describe the new functionality?

@@ -947,7 +947,7 @@ program
.description('Run an instance export')
.action(function(options) {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please adjust the description of option -d,--data <data>

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hello @tobiaslohr , I updated it. Let me know if this works or if you want me to modify anything else or if you had something else in mind.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

hmm. I grabbed the latest changes that were merged into master into my branch and the circle ci build is failing but it won't let me rerun it. I think that only had changes to the README.md so it shouldn't have really affected anything. Is there any way it can be rerun?

@al-haras al-haras closed this Nov 27, 2020
@al-haras al-haras reopened this Nov 27, 2020
@al-haras al-haras closed this Dec 29, 2020
@al-haras al-haras reopened this Dec 29, 2020
@tobiaslohr
Copy link
Contributor

Thanks again for contributing @al-haras. And sorry for the delay, we had to fix a build and test related issue first.

@tobiaslohr tobiaslohr merged commit 461689a into SalesforceCommerceCloud:master May 26, 2021
@tobiaslohr tobiaslohr added this to the 2.7.x milestone May 26, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Allow JSON file to be passed as export units configuration for instance:export
2 participants