-
Notifications
You must be signed in to change notification settings - Fork 94
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add ability to use data to read from file with instance:export #183
Conversation
hi @al-haras , thanks a lot for your contribution. Can you please adjust the description of the command to describe the new functionality? |
@@ -947,7 +947,7 @@ program | |||
.description('Run an instance export') | |||
.action(function(options) { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please adjust the description of option -d,--data <data>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hello @tobiaslohr , I updated it. Let me know if this works or if you want me to modify anything else or if you had something else in mind.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
hmm. I grabbed the latest changes that were merged into master into my branch and the circle ci build is failing but it won't let me rerun it. I think that only had changes to the README.md so it shouldn't have really affected anything. Is there any way it can be rerun?
Thanks again for contributing @al-haras. And sorry for the delay, we had to fix a build and test related issue first. |
Adds the ability to use either a file or type json to be parsed for instance:export
Potential solution for #144