Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove updatePassword from not implemented list #996

Merged
merged 1 commit into from
Feb 21, 2023
Merged

Remove updatePassword from not implemented list #996

merged 1 commit into from
Feb 21, 2023

Conversation

alexvuong
Copy link
Collaborator

Description

Types of Changes

  • Bug fix (non-breaking change that fixes an issue)
  • New feature (non-breaking change that adds functionality)
  • Documentation update
  • Breaking change (could cause existing functionality to not work as expected)
  • Other changes (non-breaking changes that does not fit any of the above)

Breaking changes include:

  • Removing a public function or component or prop
  • Adding a required argument to a function
  • Changing the data type of a function parameter or return value
  • Adding a new peer dependency to package.json

Changes

  • (change1)

How to Test-Drive This PR

  • (step1)

Checklists

General

  • Changes are covered by test cases
  • CHANGELOG.md updated with a short description of changes (not required for documentation updates)

Accessibility Compliance

You must check off all items in one of the follow two lists:

  • There are no changes to UI

or...

Localization

  • Changes include a UI text update in the Retail React App (which requires translation)

@alexvuong alexvuong requested a review from a team as a code owner February 18, 2023 00:47
@alexvuong alexvuong merged commit cc6cd1f into develop Feb 21, 2023
kevinxh added a commit that referenced this pull request Feb 23, 2023
@kevinxh @bendvc @alexvuong
Keep feature branch integrate-commerce-sdk-react up to date (#1001)
511a3dc 
* Back-port Shopper Experience Base Components into Retail Template (#992)

* Backport experience base components into template

* Fix linting

* Fix test imports

* Make types more robust

* Remove temp example page

* remove updatePw from not implemented list (#996)

---------

Co-authored-by: Ben Chypak <[email protected]>
Co-authored-by: Alex Vuong <[email protected]>
bfeister added a commit that referenced this pull request Feb 28, 2023
@bfeister
Merge branch 'develop' into spike/upgradeability
f323101 
* develop:
  Support Node 16 (#965)
  [W-12450361] Introduce short-circuit method for bypassing auth in Commerce Provider by passing in a fetchedToken (#1010)
  remove jest-silent-reporter (#1009)
  Clean up Page Designer Code (#1004)
  [Shopper Experience] `ImageWithText` component (#991)
  Feature: Page Designer Carousel Component (#977)
  [Feature] Page Designer Layout Components WIP (#993)
  remove updatePw from not implemented list (#996)
  Back-port Shopper Experience Base Components into Retail Template (#992)

# Conflicts:
#	packages/commerce-sdk-react/package-lock.json
#	packages/commerce-sdk-react/package.json
#	packages/pwa-kit-dev/package-lock.json
#	packages/pwa-kit-dev/src/configs/webpack/config.js
#	packages/template-retail-react-app/package-lock.json
@wjhsf wjhsf mentioned this pull request Mar 3, 2023
Merged
12 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kevinxh kevinxh kevinxh approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@alexvuong @kevinxh