-
Notifications
You must be signed in to change notification settings - Fork 142
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Acccount detail page hook integration #995
Merged
alexvuong
merged 13 commits into
feature/integrate-commerce-sdk-react
from
feat/account-page-details-hook-integration
Feb 24, 2023
Merged
Changes from 12 commits
Commits
Show all changes
13 commits
Select commit
Hold shift + click to select a range
f9f9a0b
accout detail page hook integration
alexvuong 7f6a340
add back redirect
alexvuong 5b287c0
minor fix, need to regen lock file
alexvuong ca93202
redirect on client only
alexvuong 817a83f
redirect on client only
alexvuong a212be9
clean up
alexvuong dddfddb
fix tests
alexvuong 3f4ce5f
Merge branch 'feature/integrate-commerce-sdk-react' into feat/account…
alexvuong 6aeb922
PR feedback
alexvuong bbab009
Linting
alexvuong 47026b9
replace appStateProvider with customerProvider
alexvuong 2d2f2ea
remove log in tests
alexvuong 2c1f981
Minor fix
alexvuong File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
20 changes: 20 additions & 0 deletions
20
packages/template-retail-react-app/app/hooks/use-current-customer.js
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,20 @@ | ||
/* | ||
* Copyright (c) 2022, Salesforce, Inc. | ||
* All rights reserved. | ||
* SPDX-License-Identifier: BSD-3-Clause | ||
* For full license text, see the LICENSE file in the repo root or https://opensource.org/licenses/BSD-3-Clause | ||
*/ | ||
|
||
/** | ||
* A hook that returns the current state of the app. | ||
* It is a combination of many commerce-sdk-react hooks that needs to be used together in many places. | ||
*/ | ||
import {useContext} from 'react' | ||
import {CustomerContext} from '../contexts' | ||
export const useCurrentCustomer = () => { | ||
const context = useContext(CustomerContext) | ||
if (context === undefined) { | ||
throw new Error('useCurrentCustomer must be used within CustomerProvider') | ||
} | ||
return context | ||
} |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
is there a particular reason why
CustomerProvider
is the parent of theMultiSiteProvider
? I'd imagine customer data is associate with a site on the backend, so i feel like it should be the other way around,MultiSiteProvider
being the parent.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good catch, it should be inside MultiSiteProvider