Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#789 added a
tail-logs
command that usesws
, but doesn't add it topackage.json
. As a result, a project that installspwa-kit-dev
as a dependency (like when they generate a project withpwa-kit-create-app
), it might come installed with an older version ofws
with a different API contract that doesn't accept aURL
instance as theaddress
argument in theWebSocket
constructor, breaking the log tailing functionality.This adds
ws
as an explicit dependency to fix that!Description
Types of Changes
Changes
ws
topackage.json
and updatepackage-lock.json
How to Test-Drive This PR
npm ci
from the repo root~/.mobify
, make sure you can tail logs withnode packages/pwa-kit-dev/bin/pwa-kit-dev.js tail-logs -p scaffold-pwa -e production
Checklists
General
Accessibility Compliance
You must check off all items in one of the follow two lists:
or...
Localization