Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Password change bug fix #803

Merged
merged 3 commits into from
Oct 28, 2022
Merged

Password change bug fix #803

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
5ada498
Restart SLAS login after pw change
yunakim714 Oct 27, 2022
c5262c3
Update comment
yunakim714 Oct 28, 2022
ff4239f
Merge branch 'develop' into change-password-relogin
bfeister Oct 28, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 10 additions & 1 deletion packages/template-retail-react-app/app/commerce-api/hooks/useCustomer.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -175,8 +175,9 @@ export default function useCustomer() {
* @param {object} data
* @param {string} data.currentPassword - The old password.
* @param {string} data.password - The new password.
* @param {string} email - Customer's email
*/
async updatePassword(data) {
async updatePassword(data, email) {
const body = {
password: data.password,
currentPassword: data.currentPassword
Expand All @@ -200,6 +201,14 @@ export default function useCustomer() {
throw new Error(json.detail)
}
}

// Send a new login request with updated password
Copy link
Collaborator

@bfeister bfeister Oct 27, 2022 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I would say "fetch a new jwt to update the invalid one in client app state"

const credentials = {
email: email,
password: data.password
}

await self.login(credentials)
},

/**
Expand Down
2 changes: 1 addition & 1 deletion packages/template-retail-react-app/app/pages/account/profile.jsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -197,7 +197,7 @@ const PasswordCard = () => {
const submit = async (values) => {
try {
form.clearErrors()
await customer.updatePassword(values)
await customer.updatePassword(values, customer.email)
setIsEditing(false)
toast({
title: formatMessage({
Expand Down