Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[pwa-kit-create-app] Update instanceUrl on retail-react-app-demo preset #799

Merged
merged 1 commit into from
Oct 27, 2022
Merged

[pwa-kit-create-app] Update instanceUrl on retail-react-app-demo preset #799

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion packages/pwa-kit-create-app/scripts/create-mobify-app.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -336,7 +336,7 @@ const testProjectAnswers = () => {
const demoProjectAnswers = () => {
const config = {
projectName: 'demo-storefront',
instanceUrl: 'https://zzte-053.sandbox.us02.dx.commercecloud.salesforce.com/',
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

i don't know if removing the ending / breaks anything?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we're good. I tested the project locally, tests are passing and we were not adding the trailing slash in our test preset.

pwa-kit/packages/pwa-kit-create-app/scripts/create-mobify-app.js

Line 324 in 7b972ee

instanceUrl: 'https://zzrf-001.sandbox.us03.dx.commercecloud.salesforce.com',

instanceUrl: 'https://zzte-053.dx.commercecloud.salesforce.com',
clientId: '1d763261-6522-4913-9d52-5d947d3b94c4',
siteId: 'RefArch',
organizationId: 'f_ecom_zzte_053',
Expand Down