Filter link on search displays results #742
Conversation
|
Still need to write tests for this change |
packages/template-retail-react-app/app/pages/product-list/index.jsx
Outdated
Show resolved
Hide resolved
| @@ -82,6 +82,20 @@ const MockedComponent = ({isLoading, isLoggedIn = false, searchQuery}) => { | |||
| </div> | |||
| )} | |||
| /> | |||
| <Route | |||
There was a problem hiding this comment.
There's no need to add a new <Route />, we can add the '/search' path to the existing <Route />:
path={[
createPathWithDefaults('/category/:categoryId'),
createPathWithDefaults('/search')
]}
| @@ -108,7 +122,6 @@ const server = setupMockServer( | |||
| ) | |||
|
|
|||
| beforeEach(() => { | |||
| window.history.pushState({}, 'ProductList', '/uk/en-GB/category/mens-clothing-jackets') | |||
There was a problem hiding this comment.
We can leave this pushState by default for the majority of the tests.
I suggest reverting this change.
There was a problem hiding this comment.
Since we are adding tests for both routes /search and /category/:id for the PLP, having module-wise navigation to the category page for all tests does not make any sense for the one that needs to navigate to the search page. I think it is better for the individual tests to handle the URL navigation instead of having a global one for all tests.
There was a problem hiding this comment.
Yes, currently there are two tests that need to navigate to the search page. For potential future test cases, I also suggest having the individual tests handle the URL navigation!
There was a problem hiding this comment.
I can see advantages for both approaches, less code vs more specific code. Either way works great in this case.
Feel free to ignore the window.history.pushState comments @yunakim714.
Co-authored-by: Adam Raya <[email protected]>
Description
Currently, when users search for an item and then apply a filter from the search results page, they are directed to a 404 error page that looks like this:
https://pwa-kit.mobify-storefront.com/en-GB/category/undefined?limit=25&q=dress&refine=c_refinementColor%3DBlack&sort=best-matches
This fix ensures that users can filter on search results.
Types of Changes
Changes
How to Test-Drive This PR
npm startChecklists
General
Accessibility Compliance
You must check off all items in one of the follow two lists:
or...
Localization