Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Search query recognizes "&" #736

Merged
merged 3 commits into from
Sep 26, 2022
Merged

Search query recognizes "&" #736

merged 3 commits into from
Sep 26, 2022

Conversation

yunakim714
Copy link
Collaborator

Description

Currently, when searching via the global header search input, any text occurring after a "&" character is truncated, resulting in an incorrect search query. With this change, the user is redirected to the search/plp page with the search query intact.

Ex)

NOTE: The API does not recognize the "&" character so the result from the API remains same as before. Thus, this is just a UI fix.

Types of Changes

  • Bug fix (non-breaking change that fixes an issue)
  • New feature (non-breaking change that adds functionality)
  • Documentation update
  • Breaking change (could cause existing functionality to not work as expected)
  • Other changes (non-breaking changes that does not fit any of the above)

Breaking changes include:

  • Removing a public function or component or prop
  • Adding a required argument to a function
  • Changing the data type of a function parameter or return value
  • Adding a new peer dependency to package.json

Changes

  • Using EncodeURIComponent() on the search query ensures that the "&" character is encoded properly

How to Test-Drive This PR

  • Checkout this branch
  • Run npm start
  • Go to http://localhost:3000/
  • Search "beers & tacos"
  • See that the search query remains intact when redirected to the search/plp page

Checklists

General

  • Changes are covered by test cases
  • CHANGELOG.md updated with a short description of changes (not required for documentation updates)

Accessibility Compliance

You must check off all items in one of the follow two lists:

  • There are no changes to UI

or...

Localization

  • Changes include a UI text update in the Retail React App (which requires translation)

@yunakim714 yunakim714 requested a review from a team as a code owner September 23, 2022 15:03
@echessman echessman requested a review from alexvuong September 23, 2022 16:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants