Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes missing required fields in manifest.json #729

Conversation

clavery
Copy link
Collaborator

@clavery clavery commented Sep 20, 2022

Description

Fixes validity issues with web app manifest

Types of Changes

  • Bug fix (non-breaking change that fixes an issue)
  • New feature (non-breaking change that adds functionality)
  • Documentation update
  • Breaking change (could cause existing functionality to not work as expected)
  • Other changes (non-breaking changes that does not fit any of the above)

Breaking changes include:

  • Removing a public function or component or prop
  • Adding a required argument to a function
  • Changing the data type of a function parameter or return value
  • Adding a new peer dependency to package.json

Changes

How to Test-Drive This PR

  • Generate a new app ./packages/pwa-kit-create-app/scripts/create-mobify-app.js
  • verify app/static/manifest.json has correct values

Checklists

General

  • [] Changes are covered by test cases
  • CHANGELOG.md updated with a short description of changes (not required for documentation updates)

Accessibility Compliance

You must check off all items in one of the follow two lists:

  • There are no changes to UI

or...

Localization

  • Changes include a UI text update in the Retail React App (which requires translation)

@clavery clavery requested a review from a team as a code owner September 20, 2022 19:39
Copy link
Collaborator

@adamraya adamraya left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you @clavery for identifying and fixing this issue!

Generated projects have been missing the short_name and name properties for a long time on the manifest.json.

@clavery clavery force-pushed the bugfix/727-missing-from-manifest branch 2 times, most recently from 1730cbc to e55e19a Compare September 21, 2022 23:13
@clavery clavery force-pushed the bugfix/727-missing-from-manifest branch from e55e19a to 6ed3dce Compare September 21, 2022 23:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[BUG] Templated web app manifest is missing name,short_name
2 participants