Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement ShopperSearch SCAPI hook #719

Merged
merged 21 commits into from
Sep 15, 2022
Merged

Conversation

shethj
Copy link
Collaborator

@shethj shethj commented Sep 15, 2022

Implement the ShopperSearch hook in the hook library so that customers can more easily consume the ShopperSearch API.
Specifically there are two hooks to be implemented: useShopperSearchSuggestions and useShopperSearchProductSearch.

Description

Types of Changes

  • Bug fix (non-breaking change that fixes an issue)
  • New feature (non-breaking change that adds functionality)
  • Documentation update
  • Breaking change (could cause existing functionality to not work as expected)
  • Other changes (non-breaking changes that does not fit any of the above)

Breaking changes include:

  • Removing a public function or component or prop
  • Adding a required argument to a function
  • Changing the data type of a function parameter or return value
  • Adding a new peer dependency to package.json

Changes

  • (change1)

How to Test-Drive This PR

  • (step1)

Checklists

General

  • Changes are covered by test cases
  • CHANGELOG.md updated with a short description of changes (not required for documentation updates)

Accessibility Compliance

You must check off all items in one of the follow two lists:

  • There are no changes to UI

or...

Localization

  • Changes include a UI text update in the Retail React App (which requires translation)

@shethj shethj added the ready for review PR is ready to be reviewed label Sep 15, 2022
@shethj shethj requested a review from a team as a code owner September 15, 2022 17:05
@shethj shethj self-assigned this Sep 15, 2022
@shethj shethj requested review from vmarta and kevinxh September 15, 2022 17:06
Copy link
Collaborator

@alexvuong alexvuong left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@shethj shethj merged commit 158b357 into develop Sep 15, 2022
@shethj shethj deleted the feat/implement-shopper-search branch September 15, 2022 17:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ready for review PR is ready to be reviewed
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants