Fix locale alias by including locale object in MultiSite Context #716
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR fixes the issue #712.
Problem
The MultiSite refactor to optimize Server-side performance PR #667, introduced a regression where the
locale.alias
defined in thesites.js
configuration is no longer working.Solution
The implemented solution follows the proposed solution in the issue #712.
The
MultiSiteContext
now includes thelocale
object including thelocale.id
andlocale.alias
and uses thelocale.alias
in URLs over thelocale.id
if thelocale.alias
is defined insites.js
configuration.Types of Changes
Changes
getSiteByReference
.How to Test-Drive This PR
locale.alias
to thepackages/template-retail-react-app/config/sites.js
configuration.E.g.
npm run start
.Verify 👇
sites.js
config file is used in the URLs (Except for the home page).Checklists
General
Accessibility Compliance
You must check off all items in one of the follow two lists:
or...
Localization