-
Notifications
You must be signed in to change notification settings - Fork 143
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add new activities to Einstein API #714
Merged
Merged
Changes from 23 commits
Commits
Show all changes
24 commits
Select commit
Hold shift + click to select a range
0a63ae0
Add new endpoints to Einstein API
vcua-mobify b3cd8f9
Update pages to send viewPage activity
vcua-mobify 65f81c6
Update checkout to send beginCheckout activity
vcua-mobify 58d7b91
Update PDP to send viewSearch and viewCategory activities
vcua-mobify df01004
Address duplicate activity calls
vcua-mobify a8f7921
Update PLP to send clickSearch and clickCategory activities
vcua-mobify a2ffb22
Include realm. Also include path location on viewPage
vcua-mobify 5d35182
Begin fixing tests
vcua-mobify 5616025
Move useEffect to before the redirect to fix an error.
vcua-mobify 2740457
Mock Einstein in product listing test
vcua-mobify 6c717ab
Fix lint
vcua-mobify f1dd3ad
Add tests for new activities
vcua-mobify d672a01
Merge branch 'develop' into einstein-api-update
bendvc 2418ffa
Add a guard for setting realm and remove correlationId for now.
vcua-mobify 1ef8fd5
Merge branch 'einstein-api-update' of github.com:SalesforceCommerceCl…
vcua-mobify 9ed86f4
Simplify activity logic in PLP
vcua-mobify f57b5e8
Fix tests
vcua-mobify 3bede9d
Fix lint
vcua-mobify 3827852
Remove pathname from home page viewPage
vcua-mobify a17b93e
Re-add pathname to home page.
vcua-mobify a982093
Refactor: use constants to represent checkout steps
vcua-mobify 4b58334
Add checkoutStep activity to Einstein API
vcua-mobify 5b56eaf
Merge branch 'develop' into einstein-api-update
vcua-mobify 52fb4fd
Merge branch 'develop' into einstein-api-update
vcua-mobify File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
No action required on this comment. But I wanted to make sure that you notice the commonalities between all these 'send' functions. There is probably room to DRY things up, but I don't expect this to be done at the moment as this Einstein work at some point will be removed from the template. It would be nice to hear your thoughts on what we might do in the future to make things more upgradable.