Fix internal build script #706
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kevinxh
commented
Aug 31, 2022
| @@ -59,8 +59,7 @@ const main = async () => { | |||
|
|
|||
| try { | |||
| // Get a list of files from the `npm pack --dry-run` command. | |||
| const packageFiles = await packlist() | |||
|
|
|||
| const packageFiles = (await packlist()).filter((path) => !path.startsWith('dist')) | |||
There was a problem hiding this comment.
This single line change is the key of this PR. (the rest is just maintenance.)
kevinxh
commented
Aug 31, 2022
| @@ -2,20 +2,16 @@ | |||
| "name": "pwa-kit-react-sdk", | |||
| "version": "2.3.0-dev", | |||
| "description": "A library that supports the isomorphic React rendering pipeline for Commerce Cloud Managed Runtime apps", | |||
| "main": "dist/index.js", | |||
There was a problem hiding this comment.
Remove it because we don't have this file in the dist folder.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
There is an issue when you run
npm run buildincommerce-sdk-react, the build in/disthas a weird folder structure where there is double/dist.This happens because the package.json has a
mainfield fordist/index.jsto specify the main entry point (this file doesn't exist in other public libraries because this is the first library in the mono repo that has an index file default export.) The PR fixes this by not copy the files that is already in dist.Types of Changes
Changes
How to Test-Drive This PR
cd packages/commerce-sdk-react && npm run buildyou should have a
/distfolder that look like this:Checklists
General
Accessibility Compliance
You must check off all items in one of the follow two lists:
or...
Localization