Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add tsconfig to typescript template projects #705

Merged
merged 3 commits into from
Aug 29, 2022

Conversation

alexvuong
Copy link
Collaborator

@alexvuong alexvuong commented Aug 29, 2022

Description

Since we don't have tsconfig in our typescript project, some editors will complain as such
image

Some will not complain, this is due to the fact that each editor will use its own default tsconfig (which is different from one editor to another) if a tsconfig is not presented in the project. To make thing consistent for all editor, we should include tsconfig file whenever we have Typescript projects.

Types of Changes

  • Bug fix (non-breaking change that fixes an issue)
  • New feature (non-breaking change that adds functionality)
  • Documentation update
  • Breaking change (could cause existing functionality to not work as expected)
  • Other changes (non-breaking changes that does not fit any of the above)

Breaking changes include:

  • Removing a public function or component or prop
  • Adding a required argument to a function
  • Changing the data type of a function parameter or return value
  • Adding a new peer dependency to package.json

Changes

  • (change1)

How to Test-Drive This PR

  • (step1)

Checklists

General

  • Changes are covered by test cases
  • CHANGELOG.md updated with a short description of changes (not required for documentation updates)

Accessibility Compliance

You must check off all items in one of the follow two lists:

  • There are no changes to UI

or...

Localization

  • Changes include a UI text update in the Retail React App (which requires translation)

@alexvuong alexvuong requested a review from a team as a code owner August 29, 2022 22:49
@alexvuong alexvuong self-assigned this Aug 29, 2022
@alexvuong alexvuong requested a review from kevinxh August 29, 2022 22:51
@@ -0,0 +1,102 @@
{
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

is everything in this file the default output of tsc --init?

@alexvuong alexvuong merged commit 4c4482b into develop Aug 29, 2022
@wjhsf wjhsf deleted the add-tsconfig-to-template-projects branch March 17, 2023 16:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants