Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

@W-12627114: Set aria label for the address forms based on the address type #1904

Merged
merged 11 commits into from
Jul 17, 2024
Merged

@W-12627114: Set aria label for the address forms based on the address type #1904

merged 11 commits into from
Jul 17, 2024

Conversation

unandyala
Copy link
Collaborator

Pass custom aria label for the address forms depending on the adress type (Billing/Shipping)

  • Bug fix (non-breaking change that fixes an issue)
  • New feature (non-breaking change that adds functionality)
  • Documentation update
  • Breaking change (could cause existing functionality to not work as expected)
  • Other changes (non-breaking changes that does not fit any of the above)

How to Test-Drive This PR

  1. Checkout code
  2. Run Retail App template
  3. Check out cart with VoiceOver (Cmd + f5)
  4. Add & Edit address with in a registered user account

@unandyala unandyala requested a review from a team as a code owner July 15, 2024 23:33
shethj
shethj previously approved these changes Jul 16, 2024
View reviewed changes
@unandyala unandyala merged commit 881428f into develop Jul 17, 2024
28 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@shethj shethj shethj approved these changes

@alexvuong alexvuong alexvuong approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@unandyala @alexvuong @shethj