@W-12627224@ Account menu a11y #1884
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
shethj
previously approved these changes
Jul 9, 2024
|
The border on the menu item looks a bit odd, was it intentional? Why does it only show border-top and border-bottom with round corners? |
|
@alexvuong I replaced the
|
alexvuong
reviewed
Jul 10, 2024
| @@ -42,20 +42,24 @@ export default { | |||
| color: 'black', | |||
| justifyContent: 'flex-start', | |||
| fontSize: 'sm', | |||
| _hover: {bg: 'gray.50', textDecoration: 'none'}, | |||
| _hover: {bg: 'gray.50', textDecoration: 'underline', textDecorationColor: '#181818'}, | |||
There was a problem hiding this comment.
Suggested change
| _hover: {bg: 'gray.50', textDecoration: 'underline', textDecorationColor: '#181818'}, | |
| _hover: {bg: 'gray.50', textDecoration: 'underline', textDecorationColor: 'gray.900'}, |
There was a problem hiding this comment.
Suggestion applied. I also replaced the blues with blue.600
joeluong-sfcc
previously approved these changes
Jul 12, 2024
|
After discussions with the UI team, we have settled on using a left border bar as shown in this screen shot 
|
alexvuong
previously approved these changes
Jul 15, 2024
joeluong-sfcc
previously approved these changes
Jul 15, 2024
Signed-off-by: vcua-mobify <[email protected]>
vcua-mobify
dismissed stale reviews from joeluong-sfcc and alexvuong
via
7fb40de
alexvuong
approved these changes
Jul 15, 2024
joeluong-sfcc
approved these changes
Jul 15, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR contains a couple of a11y fixes for the account dropdown
<p>tag on the account drop down menu headermenu-linkitems.menu-linkitems.<li>tagDesktop view changes: (Order History is active page, Account Details is hovered)
Mobile view changes: (Wishlist is active page, Order History is hovered)
Testing these changes:
<h2>instead of<p>. Also verify that the text styling is the same as before<li>