-
Notifications
You must be signed in to change notification settings - Fork 143
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
@W-12627191: add error icon to error message #1839
Conversation
@@ -29,11 +29,7 @@ import OrderSummary from '@salesforce/retail-react-app/app/components/order-summ | |||
import {useCurrentCustomer} from '@salesforce/retail-react-app/app/hooks/use-current-customer' | |||
import {useCurrentBasket} from '@salesforce/retail-react-app/app/hooks/use-current-basket' | |||
import CheckoutSkeleton from '@salesforce/retail-react-app/app/pages/checkout/partials/checkout-skeleton' | |||
import { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
FYI - just removed unused variable. NO FUNCTIONAL CHANGES in this file
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think this usid was used before when we had to pass in the SLAS usid to the SCAPI createOrder call for Einstein purposes (we no longer need to do so). We probably forgot to remove it here when we took that out.
This is safe to remove.
Thanks @unandyala . I tested the changes on my local and have verified that voiceover works on the modified error messages. One small nit however. Do we want the icon on this error message as well (appears when not all the options are selected on the PDP) |
When I apply invalid code for promocode, the error shows up, the focus should focus back to the input so the screen reader can read it out loud. Currently, the focus does not move back to the input, the screen reader will stop after you hit Apply. The users won't be able to know if the code they entered is valid or not via screen reader. Note: We can create ticket to fix this behavior if you think it takes more time than like 1hr STR
|
@vcua-mobify Yes, we need error icon on PDP as well. However this is a different issue and I will create separate ticket for this. |
@alexvuong This is fixed now |
Add error/red icon to the error message so that People who are blind, colorblind, or using a monochrome screen will be able detect error messages. This impacts multiple fields
pwa-kit_add-error-icon.mov
Types of Changes
How to Test-Drive This PR