Update SLAS private proxy path #1752
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vcua-mobify
reviewed
Apr 17, 2024
packages/template-retail-react-app/app/components/_app-config/index.jsx
Outdated
Show resolved
Hide resolved
vcua-mobify
reviewed
Apr 17, 2024
vcua-mobify
approved these changes
Apr 17, 2024
kevinxh
commented
Apr 17, 2024
| `Please make sure you have enabled the SLAS Private Client Proxy in your ssr.js and set the correct environment variable PWA_KIT_SLAS_CLIENT_SECRET.` | ||
| ) | ||
| console.error( | ||
| `SLAS Private Client Proxy Request URL - ${req.protocol}://${req.get( |
There was a problem hiding this comment.
log the full proxied request URL, this may help if user have configuration issues.
bendvc
reviewed
Apr 17, 2024
| @@ -176,7 +176,7 @@ class Auth { | |||
| constructor(config: AuthConfig) { | |||
| // Special endpoint for injecting SLAS private client secret | |||
| const baseUrl = config.proxy.split(`/mobify/proxy/api`)[0] | |||
There was a problem hiding this comment.
I think there is a bug in the waiting here as well. Since the proxy path value is configurable we might run into issues if someone was to change that.
bendvc
approved these changes
Apr 17, 2024
bendvc
approved these changes
Apr 17, 2024
alexvuong
added a commit
that referenced
this pull request
Apr 17, 2024
* fix changelog * Starting release process for 3.5.0 * Consume latest `commerce-sdk-isomorphic` (#1743) * bump isomorphic sdk version * fix param keys * upgrade to 1.13.1 * Release 3.5.0 - SLAS Private Client Support (#1747) * bump version to 3.5.0 and update CHANGELOGs * fix versions and changelogs * fix lock file versions * fix package version * fix package version 2 * use npm on both win and mac platforms * Revert "use npm on both win and mac platforms" This reverts commit 63b402f. * debug ci * try shell:true * more shell:true * Update scripts/check-version.js Signed-off-by: Kevin He <[email protected]> --------- Signed-off-by: Kevin He <[email protected]> * add missing param keys for shopper search * PR feedback * bump retail app version * add changelog for retail react app template * Update SLAS private proxy path (#1752) * update private path to /mobify/slas/private * update proxy path and add loggings * disable private client by default * bump versions * update develop with 3.5.2 realease * update changelog * update changelog --------- Signed-off-by: Kevin He <[email protected]> Co-authored-by: Kevin He <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
I want to propose we change the SLAS Private client proxy path from
/mobify/scapi/shopper/authto/mobify/slas/private.The reason is that the full path of the existing proxy shows duplicated path segments like
/mobify/scapi/shopper/auth/shopper/auth/v1/organizations/f_ecom_zzrf_002/oauth2/token, this may confuse users who think there are something wrong with the duplicated path/shopper/auth/shopper/authAlso added some loggings to help debug failed proxy requests.
If we agree with this change, i will release a new patch version
Types of Changes
Changes
How to Test-Drive This PR
Checklists
General
Accessibility Compliance
You must check off all items in one of the follow two lists:
or...
Localization