Begin development on v3.6.0 #1749
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* bump isomorphic sdk version * fix param keys * upgrade to 1.13.1
* bump version to 3.5.0 and update CHANGELOGs * fix versions and changelogs * fix lock file versions * fix package version * fix package version 2 * use npm on both win and mac platforms * Revert "use npm on both win and mac platforms" This reverts commit 63b402f. * debug ci * try shell:true * more shell:true * Update scripts/check-version.js Signed-off-by: Kevin He <[email protected]> --------- Signed-off-by: Kevin He <[email protected]>
alexvuong
reviewed
Apr 16, 2024
alexvuong
reviewed
Apr 16, 2024
alexvuong
reviewed
Apr 16, 2024
alexvuong
reviewed
Apr 16, 2024
alexvuong
reviewed
Apr 16, 2024
bendvc
reviewed
Apr 16, 2024
bendvc
reviewed
Apr 16, 2024
|
Please refer to #1753 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
after releasing v3.5.0, this PR bumps the version for the next release.
During the release, we found out that the CI pipeline was broken due to a recent Node18/20 security patch.
child_process.spawnSync('npm.cmd')no longer works in the latest security patches, on Windows.So we updated the instances to include
{shell:true}, which appears to resolve this issue.references -
https://discourse.nodered.org/t/not-starting-on-window-11-error-spawn-einval/87153
microsoft/rushstack#4636
node-red/node-red#4652 (comment)
nodejs/node#52475