Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[W-15226710] Fix promo code application #1692

Merged
merged 4 commits into from
Mar 11, 2024

Conversation

bendvc
Copy link
Collaborator

@bendvc bendvc commented Mar 11, 2024

Description

This fixes issue #1628

Types of Changes

  • Bug fix (non-breaking change that fixes an issue)
  • New feature (non-breaking change that adds functionality)
  • Documentation update
  • Breaking change (could cause existing functionality to not work as expected)
  • Other changes (non-breaking changes that does not fit any of the above)

Changes

  • Use async API so that the form handler isn't always a success.

How to Test-Drive This PR

  • Add an item to your cart
  • View your cart
  • In the side bar add a promo code "test"
  • You should se an error because there is no promo with that code, but the form is still visible.
  • Now try "orderLevel"
  • You should see a toast and the form go away, and a successful promo added.
  • Remove the promo
  • All is good.

Checklists

General

  • Changes are covered by test cases
  • CHANGELOG.md updated with a short description of changes (not required for documentation updates)

Accessibility Compliance

You must check off all items in one of the follow two lists:

  • There are no changes to UI

or...

Localization

  • Changes include a UI text update in the Retail React App (which requires translation)

@bendvc bendvc requested a review from a team as a code owner March 11, 2024 16:57
@bendvc bendvc requested a review from alexvuong March 11, 2024 16:58
alexvuong
alexvuong previously approved these changes Mar 11, 2024
alexvuong
alexvuong previously approved these changes Mar 11, 2024
kevinxh
kevinxh previously approved these changes Mar 11, 2024
@bendvc bendvc dismissed stale reviews from kevinxh and alexvuong via 3dd1865 March 11, 2024 20:39
@bendvc bendvc merged commit 4dbeb1a into develop Mar 11, 2024
28 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants