W-13546967 - Fix change password form #1634
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bendvc
changed the title
alexvuong
approved these changes
Jan 5, 2024
|
Thanks for posting those videos, they are very helpful! |
bfeister
reviewed
Jan 5, 2024
Comment on lines
-286
to
-293
| toast({ | ||
| title: formatMessage({ | ||
| defaultMessage: 'Password updated', | ||
| id: 'password_card.info.password_updated' | ||
| }), | ||
| status: 'success', | ||
| isClosable: true | ||
| }) |
There was a problem hiding this comment.
Not a blocking comment, but I notice we're changing the UX and no longer showing a "✅ success" message. Does it not work with the altered functionality?
There was a problem hiding this comment.
This was a duplicate that was erroneously being shown either when there was an error or for a second time if it succeeded
bfeister
approved these changes
Jan 5, 2024
This was
linked to
issues
Jan 8, 2024
This was referenced Jan 8, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
The "change password" form in V3 isn't working as expected as a result of a code regression. This was most likely due to the hook integration work. The user was able to change their password, but the follow up action of logging in with said new password would fail as the login action was being called with the wrong arguments. Additionally, no error was being shown and 2 success toasts were being displayed.
This PR fixes all these issues and adds some tests to ensure another regression doesn't happen.
In the below recording you'll see the broken behaviour. First I try to change the password using a current password that isn't the actual value, and as you can see, it visually succeeds. Next I try to change the password to something new using the actual current password, and as you can see there is a login error in the network window.
PasswordUpdateBroken.mov
Now in the recording below I do similar actions to which they are all working.
PasswordChangeFixed.mov
Types of Changes
Changes
How to Test-Drive This PR
Checklists
General