-
Notifications
You must be signed in to change notification settings - Fork 143
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
@W-14338017@ Fix: accessibility focus for my account pages and promo code #1625
Conversation
...ate-retail-react-app/app/pages/account/wishlist/partials/wishlist-secondary-button-group.jsx
Outdated
Show resolved
Hide resolved
packages/template-retail-react-app/app/pages/checkout/partials/shipping-address-selection.jsx
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Similarly, we are missing handling the focus when users click the Cancel or Save buttons on the form opened by clicking the 'Edit' button in the Account Details page.
<FormActionButtons onCancel={() => setIsEditing(false)} /> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There wasn't a straightforward way to maintain a reference to the edit buttons since the edit buttons disappear from the DOM when in edit mode and get re-rendered after the form is closed, so for now I set the focus to the Profile/Password heading when you click the Cancel/Save buttons in edit mode
Description
This PR fixes several focus accessibility issues:
Wishlist
heading instead of onto the bodyAddresses
heading on the Addresses pageShipping Addresses
headingTypes of Changes
Changes
How to Test-Drive This PR
git checkout ju/fix-focus.W-14338017
npm ci
cd packages/template-retail-react-app
npm run start
Checklists
General
Accessibility Compliance
You must check off all items in one of the follow two lists:
or...
Localization