@W-14599658@ Fix: update packages to include npm 10 #1597
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…/pwa-kit into ju/update-npm-10
wjhsf
approved these changes
Dec 5, 2023
| npm: [8, 9, 10] | ||
| exclude: # node 16 is not compatible with npm 10 | ||
| - node: 16 | ||
| npm: 10 | ||
| runs-on: ubuntu-latest | ||
| env: | ||
| # The "default" npm is the one that ships with a given version of node. |
There was a problem hiding this comment.
Does CI run with node 18.0 or latest 18? As of node 18.19.0, the default npm is now 10.
There was a problem hiding this comment.
Based on the CI, seems like its actually v18.18.2, should we try to pin it to a version greater than or equal to v18.19.0?
There was a problem hiding this comment.
v18.19.0 was only released last week, so it seems like the tooling does use latest 18, but just hasn't pulled in the new release yet. I'd say leave keep what we have for now, but set a reminder to double check in like a week or two, maybe?
vmarta
approved these changes
Dec 6, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Starting with Node
v18.19.0, npm is updated to v10, meaning anytime anyone tries to runnpm iwith Node version greater thanv18.19.0they error out since all packages look for"npm":"^8.0.0 || ^9.0.0". This PR adds in npm 10.This PR also updates the CI to include npm 10, and excludes the combination of node 16 with npm 10 from the testing matrix as they are incompatible
Related Github Issue: #1594
Types of Changes
Changes
How to Test-Drive This PR
Checklists
General
Accessibility Compliance
You must check off all items in one of the follow two lists:
or...
Localization