Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

@W-12627159 - Use aria-disabled in pagination prev and next buttons #1570

Merged
merged 2 commits into from
Nov 28, 2023
Merged

@W-12627159 - Use aria-disabled in pagination prev and next buttons #1570

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
dbdbbfd
Use aria-disabled in pagination prev and next buttons
adamraya Nov 28, 2023
ce2303a
Update CHANGELOG.md
adamraya Nov 28, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions packages/template-retail-react-app/CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -12,6 +12,7 @@
- Make security code tooltip receive keyboard focus [#1551](https://github.com/SalesforceCommerceCloud/pwa-kit/pull/1551)
- Improve accessibility of quantity picker [#1552](https://github.com/SalesforceCommerceCloud/pwa-kit/pull/1552)
- Improve keyboard accessibility of product scroller [#1559](https://github.com/SalesforceCommerceCloud/pwa-kit/pull/1559)
- Ensure color is not the sole means of communicating information [#1570](https://github.com/SalesforceCommerceCloud/pwa-kit/pull/1570)

### Other Features

Expand Down
4 changes: 2 additions & 2 deletions packages/template-retail-react-app/app/components/pagination/index.jsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -54,7 +54,7 @@ const Pagination = (props) => {
href={prev || currentURL}
to={prev || currentURL}
aria-label="Previous Page"
isDisabled={!prev}
aria-disabled={!prev}
variant="link"
>
<ChevronLeftIcon />
Expand Down Expand Up @@ -103,7 +103,7 @@ const Pagination = (props) => {
href={next || currentURL}
to={next || currentURL}
aria-label="Next Page"
isDisabled={!next}
aria-disabled={!next}
variant="link"
>
<Text>
Expand Down