@W-12627180@ Improve keyboard accessibility of product scroller #1559
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Skeleton tiles are a visual placeholder, so they don't really need to be scrolled.
Clarify if the action is add/remove Specify which product is being toggled
alexvuong
reviewed
Nov 21, 2023
packages/template-retail-react-app/app/components/product-tile/index.jsx
Outdated
Show resolved
Hide resolved
alexvuong
reviewed
Nov 21, 2023
packages/template-retail-react-app/app/components/product-scroller/index.jsx
Outdated
Show resolved
Hide resolved
Co-authored-by: Alex Vuong <[email protected]> Signed-off-by: Will Harney <[email protected]>
Signed-off-by: Will Harney <[email protected]>
alexvuong
previously approved these changes
Nov 21, 2023
vmarta
reviewed
Nov 21, 2023
Comment on lines
138
to
154
| aria-label={ | ||
| isFavourite | ||
| ? intl.formatMessage( | ||
| { | ||
| id: 'product_tile.assistive_msg.add_to_wishlist', | ||
| defaultMessage: 'Add {product} to wishlist' | ||
| }, | ||
| {product: localizedProductName} | ||
| ) | ||
| : intl.formatMessage( | ||
| { | ||
| id: 'product_tile.assistive_msg.remove_from wishlist', | ||
| defaultMessage: 'Remove {product} from wishlist' | ||
| }, | ||
| {product: localizedProductName} | ||
| ) | ||
| } |
There was a problem hiding this comment.
The order of the messages should be reversed: if it's favourite, then clicking the icon means removing the product from wishlist.
Signed-off-by: Will Harney <[email protected]>
alexvuong
previously approved these changes
Nov 22, 2023
vmarta
approved these changes
Nov 22, 2023
alexvuong
approved these changes
Nov 22, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
(<)(>)scroll left/right buttons are no longer rendered with the skeleton, since the skeleton is not interactiveBefore:
(very subtle in top left / bottom left corners)
After:
Types of Changes
Changes
How to Test-Drive This PR
Checklists
General
Accessibility Compliance
You must check off all items in one of the follow two lists:
or...
Localization