Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

@W-13969523 Add Active Data change to CHANGELOG #1558

Merged
merged 2 commits into from
Nov 29, 2023
Merged

Conversation

bfeister
Copy link
Collaborator

Description

This PR adds the missing CHANGELOG change to account for the Active Data work in #1555

Types of Changes

  • Bug fix (non-breaking change that fixes an issue)
  • New feature (non-breaking change that adds functionality)
  • Documentation update
  • Breaking change (could cause existing functionality to not work as expected)
  • Other changes (non-breaking changes that does not fit any of the above)

Breaking changes include:

  • Removing a public function or component or prop
  • Adding a required argument to a function
  • Changing the data type of a function parameter or return value
  • Adding a new peer dependency to package.json

Changes

  • (change1)

How to Test-Drive This PR

  • (step1)

Checklists

General

  • Changes are covered by test cases
  • CHANGELOG.md updated with a short description of changes (not required for documentation updates)

Accessibility Compliance

You must check off all items in one of the follow two lists:

  • There are no changes to UI

or...

Localization

  • Changes include a UI text update in the Retail React App (which requires translation)

@bfeister bfeister requested a review from a team as a code owner November 21, 2023 18:49
alexvuong
alexvuong previously approved these changes Nov 21, 2023
wjhsf
wjhsf previously approved these changes Nov 21, 2023
@bfeister bfeister enabled auto-merge November 29, 2023 20:01
# Conflicts:
#	packages/template-retail-react-app/CHANGELOG.md
@bfeister bfeister dismissed stale reviews from wjhsf and alexvuong via dfc0b29 November 29, 2023 20:09
@bfeister bfeister merged commit b8f77c8 into develop Nov 29, 2023
20 checks passed
@joeluong-sfcc joeluong-sfcc deleted the W-13969523.changelog branch November 29, 2023 20:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants