Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

@W-14446652@ v2 Change CSP enforcement to an opt-in middleware. #1530

Merged
merged 4 commits into from
Nov 8, 2023
Merged

@W-14446652@ v2 Change CSP enforcement to an opt-in middleware. #1530

merged 4 commits into from
Nov 8, 2023

Conversation

wjhsf
Copy link
Contributor

@wjhsf wjhsf commented Nov 8, 2023

Port of #1528 for v2. See that PR for details.

Description

Types of Changes

  • Bug fix (non-breaking change that fixes an issue)
  • New feature (non-breaking change that adds functionality)
  • Documentation update
  • Breaking change (could cause existing functionality to not work as expected)
  • Other changes (non-breaking changes that does not fit any of the above)

Breaking changes include:

  • Removing a public function or component or prop
  • Adding a required argument to a function
  • Changing the data type of a function parameter or return value
  • Adding a new peer dependency to package.json

Changes

  • (change1)

How to Test-Drive This PR

  • (step1)

Checklists

General

  • Changes are covered by test cases
  • CHANGELOG.md updated with a short description of changes (not required for documentation updates)

Accessibility Compliance

You must check off all items in one of the follow two lists:

  • There are no changes to UI

or...

Localization

  • Changes include a UI text update in the Retail React App (which requires translation)

@wjhsf
@W-14446652@ Change CSP enforcement to an opt-in middleware. (#1528)
851fa19 
* Declare constant in file that uses it.

* Update CHANGELOGs.

* Move CSP middleware to utils.

* Naming things is hard.

* Renaming things is hard.

* Don't touch files that don't need to be touched.

* Re-delete moved code.

* Remove outdated comment.
@wjhsf wjhsf requested a review from a team as a code owner November 8, 2023 01:42
wjhsf
wjhsf commented Nov 8, 2023
View reviewed changes
packages/template-retail-react-app/CHANGELOG.md
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All the changes for prior releases are just markdownlint auto fixes.

@wjhsf wjhsf enabled auto-merge November 8, 2023 19:04
vmarta
vmarta reviewed Nov 8, 2023
View reviewed changes
packages/pwa-kit-runtime/CHANGELOG.md Outdated Show resolved Hide resolved
packages/template-retail-react-app/CHANGELOG.md Outdated Show resolved Hide resolved
@vmarta
Fix PR links
d6d3deb 
Signed-off-by: Vincent Marta <[email protected]>
@wjhsf wjhsf merged commit 789919f into release-2.8.x Nov 8, 2023
26 checks passed
@vmarta vmarta mentioned this pull request Nov 8, 2023
Merged
12 tasks
@wjhsf wjhsf deleted the wjh/v2-fix-csp branch November 16, 2023 17:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@alexvuong alexvuong alexvuong approved these changes

@vmarta vmarta vmarta approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@wjhsf @vmarta @alexvuong