-
Notifications
You must be signed in to change notification settings - Fork 143
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Storefront Preview 🔍 ] Add "onContextChange" Property to StorefrontPreview Component #1527
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add "onContextChange" prop to StorefrontPreview component.
bendvc
commented
Nov 7, 2023
packages/template-retail-react-app/app/components/_app/index.jsx
Outdated
Show resolved
Hide resolved
bendvc
commented
Nov 7, 2023
packages/commerce-sdk-react/src/components/StorefrontPreview/storefront-preview.tsx
Outdated
Show resolved
Hide resolved
wjhsf
reviewed
Nov 10, 2023
packages/commerce-sdk-react/src/components/StorefrontPreview/storefront-preview.tsx
Outdated
Show resolved
Hide resolved
packages/commerce-sdk-react/src/components/StorefrontPreview/storefront-preview.tsx
Outdated
Show resolved
Hide resolved
packages/commerce-sdk-react/src/components/StorefrontPreview/storefront-preview.tsx
Outdated
Show resolved
Hide resolved
packages/commerce-sdk-react/src/components/StorefrontPreview/storefront-preview.tsx
Outdated
Show resolved
Hide resolved
…torefront-preview.tsx Co-authored-by: Will Harney <[email protected]> Signed-off-by: Ben Chypak <[email protected]>
adamraya
previously approved these changes
Nov 14, 2023
…torefront-preview.tsx Co-authored-by: Will Harney <[email protected]> Signed-off-by: Ben Chypak <[email protected]>
…om/SalesforceCommerceCloud/pwa-kit into storefront-preview-oncontextchange
wjhsf
approved these changes
Nov 17, 2023
bendvc
commented
Nov 17, 2023
adamraya
approved these changes
Nov 17, 2023
joeluong-sfcc
added a commit
that referenced
this pull request
Dec 5, 2023
12 tasks
joeluong-sfcc
added a commit
that referenced
this pull request
Dec 6, 2023
This reverts commit 2164c3a.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This is the companion PR for #466 in the Runtime-Admin project.
The goal in this PR is the expose the context changed message event in the form of a handler. This will allow StorefrontPreview implementers to define this handler and take the context and do what they want with it. The use case we are looking at is to integrate 3rd party CMS's like Amplience.
Types of Changes
Changes
onContextChange
prop to StorefrontPreview component.How to Test-Drive This PR
Checklists
General
Accessibility Compliance
You must check off all items in one of the follow two lists:
or...
Localization