Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Release SDK 2.8.0-preview.0 #1516

Merged
merged 3 commits into from
Nov 3, 2023
Merged

Release SDK 2.8.0-preview.0 #1516

merged 3 commits into from
Nov 3, 2023

Conversation

vmarta
Copy link
Contributor

@vmarta vmarta commented Nov 2, 2023

What's new in 2.8.0: see #1507

  • Update changelog files

Types of Changes

  • Bug fix (non-breaking change that fixes an issue)
  • New feature (non-breaking change that adds functionality)
  • Documentation update
  • Breaking change (could cause existing functionality to not work as expected)
  • Other changes (non-breaking changes that does not fit any of the above)

Breaking changes include:

  • Removing a public function or component or prop
  • Adding a required argument to a function
  • Changing the data type of a function parameter or return value
  • Adding a new peer dependency to package.json

Changes

  • (change1)

How to Test-Drive This PR

  • (step1)

Checklists

General

  • Changes are covered by test cases
  • CHANGELOG.md updated with a short description of changes (not required for documentation updates)

Accessibility Compliance

You must check off all items in one of the follow two lists:

  • There are no changes to UI

or...

Localization

  • Changes include a UI text update in the Retail React App (which requires translation)

@vmarta vmarta changed the title Release 2.8.0-preview.0 Release SDK 2.8.0-preview.0 Nov 2, 2023
@vmarta vmarta marked this pull request as ready for review November 2, 2023 22:54
@vmarta vmarta requested a review from a team as a code owner November 2, 2023 22:54
Comment on lines 2 to +3
"name": "commerce-sdk-react-preview",
"version": "2.7.4",
"version": "2.8.0-preview.0",
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do we want to release a new version of commerce-sdk-react-preview?

Knowing that the final version is living on NPM @salesforce/commerce-sdk-react

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@adamraya this will not be published because the package is marked as private: true.

Copy link
Contributor

@vcua-mobify vcua-mobify left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The only change mentioned in the change logs is the moving of the CSP headers into runtime.

In #1507 there are entries for adding Storefront preview support. Should those be added here as well?

Edit: I see where those entries are now; they are already included.

@vmarta vmarta merged commit edd0440 into release-2.8.x Nov 3, 2023
@vmarta vmarta deleted the prep-release-2.8.0 branch November 3, 2023 00:00
@vmarta vmarta mentioned this pull request Nov 3, 2023
12 tasks
@wjhsf wjhsf mentioned this pull request Nov 8, 2023
12 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants