Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

@W-13824911@ Fix pwa-kit-dev start failing to find app entrypoint. #1380

Merged
merged 1 commit into from
Jul 25, 2023

Conversation

wjhsf
Copy link
Contributor

@wjhsf wjhsf commented Jul 25, 2023

In #1376, I fixed one bug and introduced another!

Description

Before: Running npm start in a generated app doesn't work
After: Running npm start in a generated app does work!

Types of Changes

  • Bug fix (non-breaking change that fixes an issue)
  • New feature (non-breaking change that adds functionality)
  • Documentation update
  • Breaking change (could cause existing functionality to not work as expected)
  • Other changes (non-breaking changes that does not fit any of the above)

Breaking changes include:

  • Removing a public function or component or prop
  • Adding a required argument to a function
  • Changing the data type of a function parameter or return value
  • Adding a new peer dependency to package.json

Changes

  • (change1)

How to Test-Drive This PR

  • (step1)

Checklists

General

  • Changes are covered by test cases
  • CHANGELOG.md updated with a short description of changes (not required for documentation updates)

Accessibility Compliance

You must check off all items in one of the follow two lists:

  • There are no changes to UI

or...

Localization

  • Changes include a UI text update in the Retail React App (which requires translation)

@wjhsf wjhsf requested a review from a team as a code owner July 25, 2023 19:43
@wjhsf wjhsf merged commit 0f2c123 into develop Jul 25, 2023
@wjhsf wjhsf deleted the wjh/fix-pwa-kit-dev-again branch July 25, 2023 20:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants