-
Notifications
You must be signed in to change notification settings - Fork 143
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Send package versions as bundle metadata #1354
Conversation
…ceCommerceCloud/pwa-kit into upload-package-version-metadata
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@yunakim714 will there be a follow-up PR for ccExtensibility.overridesDir
fs read + push to this payload?
@bfeister Yup! This PR is focused on sending just the package versions |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just going to officially say that I'll need more convincing that it's ok to lower test coverage, we'll discuss in person
…ceCommerceCloud/pwa-kit into upload-package-version-metadata
Description
One of the main goals of the Bundle Metadata Upload work for the CC SteelArc team is to gather information on the packages and versions that constitute our customers' projects.
Utilizing the project's
package.json
, we will upload thedependencies
anddevDependencies
as part of thebundle_metadata
field of the Bundle modelTypes of Changes
Changes
getProjectPkg()
function, access thepackage.json
'sdependencies
anddevDependencies
fieldsssr_parameters
How to Test-Drive This PR
portal_app
and checkout the branch... pwa-kit-dev.js push -m "Test bundle_metadata is sending" --cloud-origin http://cloud-dev.mobify.com:8000
bundle_metadata
field of the pushed bundle is populated with the project dependencies and versions in the following format:bundle_metadata: { "dependencies": { "package_a": "1.0.0", "package_b": "2.0.0" } }
Checklists
General
Accessibility Compliance
You must check off all items in one of the follow two lists:
or...
Localization