Change cc-nx-g expiry to 30 days #1342
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
According to our documentation, logged in users refresh tokens (saved as cc-nx) are valid for 90 days in production. Meanwhile guest refresh tokens (saved as cc-nx-g) are valid for only 30 days in production.
PWA Kit currently sets both cc-nx-g and cc-nx cookies to live for 90 days.
This PR changes the expiry of cc-nx-g cookies to match the validity period of guest refresh tokens.
NOTE: DO NOT MERGE UNTIL THE SAME CHANGE CAN BE MADE IN Plugin_SLAS (see https://github.com/SalesforceCommerceCloud/plugin_slas/pull/153)
We want to make this change in both PWA and plugin_SLAS so that the expiry times remain consistent on hybrid sites.