Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support Node 18 and NPM 9 in PWA Kit v2 #1265

Merged
merged 28 commits into from
Jun 17, 2023
Merged

Conversation

shethj
Copy link
Collaborator

@shethj shethj commented Jun 14, 2023

Description

The PR updates engines and CI config to support Node 18 in PWA Kit.

We keep ssrFunctionNodeVersion: '16.x' until MRT provides support to Node 18.

We keep using lockfileVersion:2 which is compatible with NPM 6, 7, 8 and 9 until we drop support for Node 14 and NPM 6.

We can re-generate lock files using lockfileVersion:2 by using NPM 7 or NPM 8 and also with NPM 9 using the --lockfile-version 2 flag.

npm i --lockfile-version 2

Types of Changes

  • Bug fix (non-breaking change that fixes an issue)
  • New feature (non-breaking change that adds functionality)
  • Documentation update
  • Breaking change (could cause existing functionality to not work as expected)
  • Other changes (non-breaking changes that does not fit any of the above)

Breaking changes include:

  • Removing a public function or component or prop
  • Adding a required argument to a function
  • Changing the data type of a function parameter or return value
  • Adding a new peer dependency to package.json

Changes

  • (change1)

How to Test-Drive This PR

  • (step1)

Checklists

General

  • Changes are covered by test cases
  • CHANGELOG.md updated with a short description of changes (not required for documentation updates)

Accessibility Compliance

You must check off all items in one of the follow two lists:

  • There are no changes to UI

or...

Localization

  • Changes include a UI text update in the Retail React App (which requires translation)

@shethj shethj requested a review from a team as a code owner June 14, 2023 15:12
@shethj shethj requested a review from adamraya June 16, 2023 19:29
@shethj shethj requested a review from adamraya June 16, 2023 20:52
Copy link
Collaborator

@adamraya adamraya left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why are we using "lockfileVersion": 1 in template-retail-react-app/package-lock.json file? It should be using "lockfileVersion": 2.

@shethj shethj requested a review from adamraya June 16, 2023 23:37
Copy link
Collaborator

@adamraya adamraya left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@shethj shethj merged commit 5dceafa into release-2.7.x Jun 17, 2023
@kevinxh kevinxh mentioned this pull request Jun 20, 2023
1 task
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants