Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Hotfix] 2.7.2 Add missing @babel dependency #1231

Merged
merged 3 commits into from
May 29, 2023

Conversation

bendvc
Copy link
Collaborator

@bendvc bendvc commented May 29, 2023

This PR is a hotfix to add a missing dependency in pwa-kit-dev which causes any generated project not to start. We are also bumping the version to 2.7.2-preview.0.

If all goes well there will be a follow up PR to bump to 2.7.2

To test this generate a project using the following commands

// clear npx cache
> rm -rf ~/.npm/_npx
// generate project using demo instance
> node packages/pwa-kit-create-app/scripts/create-mobify-app-dev.js --outputDir generated-project
// move to generated project and start
> cd generate-project && npm start

@bendvc bendvc requested a review from a team as a code owner May 29, 2023 20:24
@bendvc bendvc requested a review from vmarta May 29, 2023 20:33
@bendvc bendvc merged commit 5112f97 into release-2.7.x May 29, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants