Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[V2] Add unimplemented methods from commerce-sdk-isomorphic 1.10.1 #1190

Closed
wants to merge 1 commit into from
+9 −1
Closed

[V2] Add unimplemented methods from commerce-sdk-isomorphic 1.10.1 #1190

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 9 additions & 1 deletion packages/commerce-sdk-react/src/hooks/ShopperBaskets/index.test.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -16,7 +16,15 @@ describe('Shopper Baskets hooks', () => {
const unimplemented = getUnimplementedEndpoints(ShopperBaskets, queries, mutations)
// If this test fails: create a new query hook, add the endpoint to the mutations enum,
// or add it to the `expected` array with a comment explaining "TODO" or "never" (and why).
expect(unimplemented).toEqual([])

// these new endpoints will not be released in SDK V2
expect(unimplemented).toEqual([
'updateAsAgentBasket',
'addPriceAdjustmentToBasket',
'removePriceAdjustmentFromBasket',
'updatePriceAdjustmentInBasket',
'updateAsStorefrontBasket'
])
})
test('all mutations have cache update logic', () => {
// unimplemented = value in mutations enum, but no method in cache update matrix
Expand Down