Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[V2] Re-generate lock files and fix hook lib tests #1186

Merged
merged 8 commits into from
May 10, 2023
Merged

[V2] Re-generate lock files and fix hook lib tests #1186

Show file tree
Hide file tree
Changes from 2 commits
Commits
Show all changes
8 commits
Select commit Hold shift + click to select a range
d8c2a09
re-generate lock files and fix test
kevinxh May 10, 2023
85ffb7b
Merge branch 'develop' into fix-hooks-test
vcua-mobify May 10, 2023
350ab67
Update packages/commerce-sdk-react/src/hooks/ShopperBaskets/index.tes…
vcua-mobify May 10, 2023
3d5c0cb
Rebuild lockfiles using node 14 npm 8
vcua-mobify May 10, 2023
ba5e7ad
Revert "Rebuild lockfiles using node 14 npm 8"
vcua-mobify May 10, 2023
f46d83e
Use pwa-kit-dev for lint and format
vcua-mobify May 10, 2023
3e894d0
Revert "Use pwa-kit-dev for lint and format"
vcua-mobify May 10, 2023
2c2807f
Add typescript to internal-lib-build and rebuild lock files
vcua-mobify May 10, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9,297 changes: 4,663 additions & 4,634 deletions packages/commerce-sdk-react/package-lock.json
View file
Open in desktop

Large diffs are not rendered by default.

10 changes: 9 additions & 1 deletion packages/commerce-sdk-react/src/hooks/ShopperBaskets/index.test.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -16,7 +16,15 @@ describe('Shopper Baskets hooks', () => {
const unimplemented = getUnimplementedEndpoints(ShopperBaskets, queries, mutations)
// If this test fails: create a new query hook, add the endpoint to the mutations enum,
// or add it to the `expected` array with a comment explaining "TODO" or "never" (and why).
expect(unimplemented).toEqual([])

vcua-mobify marked this conversation as resolved.
Show resolved Hide resolved
// these new endpoints will not be released in SDK V2
expect(unimplemented).toEqual([
'updateAsAgentBasket',
'addPriceAdjustmentToBasket',
'removePriceAdjustmentFromBasket',
'updatePriceAdjustmentInBasket',
'updateAsStorefrontBasket'
])
})
test('all mutations have cache update logic', () => {
// unimplemented = value in mutations enum, but no method in cache update matrix
Expand Down
Loading