Snyk dependency updates #1169
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -31,9 +31,9 @@ | |
| }, | ||
| "dependencies": { | ||
| "@loadable/babel-plugin": "^5.15.3", | ||
| "aws-sdk": "^2.1354.0", | ||
| "aws-serverless-express": "3.4.0", | ||
| "cosmiconfig": "^8.1.3", | ||
|
There was a problem hiding this comment. Snyk created the PR to fix Did we confirm the issue is exploitable? If so you'll want to apply the same fix in There was a problem hiding this comment. We use |
||
| "cross-env": "^5.2.1", | ||
| "express": "^4.18.2", | ||
| "header-case": "1.0.1", | ||
|
|
||
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Did you confirm if the
aws-sdkissue is exploitable in the context ofpwa-kit-runtimeand in thepwa-kit-react-sdk?If it's, you'll also want to apply the same fix to
[email protected], the branch where Snyk created the original PR: #1151There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You will probably want to apply the same fix to the
v3branch.The Snyk PR merged in
v3only addresses thecosmiconfigbump but not theaws-sdkversion bump: #1145There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
In newer versions (PWA Kit 2.x and above),
aws-sdkis only used to in the runtime to instantiate a Cloudwatch client for sending metrics.In PWA Kit 1.x, it is also used to set up an AWS client for setting up the persistent cache.
For both, it will only run server side so it should not be exploitable.