Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Snyk dependency updates #1169

Merged
merged 3 commits into from
May 4, 2023
Merged

Snyk dependency updates #1169

Show file tree
Hide file tree
Changes from 2 commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
8177c89
Dependency updates
vcua-mobify May 3, 2023
42584e3
Update runtime package lock
vcua-mobify May 3, 2023
79cf4b6
Bump cosmiconfig version to latest
vcua-mobify May 3, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
130 changes: 70 additions & 60 deletions packages/pwa-kit-runtime/package-lock.json
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

4 changes: 2 additions & 2 deletions packages/pwa-kit-runtime/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -31,9 +31,9 @@
},
"dependencies": {
"@loadable/babel-plugin": "^5.15.3",
"aws-sdk": "^2.1340.0",
"aws-sdk": "^2.1354.0",
Copy link
Collaborator

@adamraya adamraya May 3, 2023 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Did you confirm if the aws-sdk issue is exploitable in the context of pwa-kit-runtime and in the pwa-kit-react-sdk?

If it's, you'll also want to apply the same fix to [email protected], the branch where Snyk created the original PR: #1151

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You will probably want to apply the same fix to the v3 branch.
The Snyk PR merged in v3 only addresses the cosmiconfig bump but not the aws-sdk version bump: #1145

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In newer versions (PWA Kit 2.x and above), aws-sdk is only used to in the runtime to instantiate a Cloudwatch client for sending metrics.

In PWA Kit 1.x, it is also used to set up an AWS client for setting up the persistent cache.

For both, it will only run server side so it should not be exploitable.

"aws-serverless-express": "3.4.0",
"cosmiconfig": "^7.1.0",
"cosmiconfig": "^8.0.0",
vcua-mobify marked this conversation as resolved.
Show resolved Hide resolved
"cross-env": "^5.2.1",
"express": "^4.18.2",
"header-case": "1.0.1",
Expand Down