Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade to React 18 #1166

Merged
merged 55 commits into from
May 15, 2023
Merged
Changes from 1 commit
Commits
Show all changes
55 commits
Select commit Hold shift + click to select a range
43be7eb
upgrade to React 18
alexvuong May 2, 2023
05157af
fix styling and hydration error
alexvuong May 2, 2023
8ee458a
fix hydration error
alexvuong May 3, 2023
09890a1
clean up
alexvuong May 4, 2023
0f246b4
fix forms
alexvuong May 4, 2023
2530ac7
fix comment
alexvuong May 5, 2023
08b7f8c
minor fix
alexvuong May 5, 2023
9967e42
fix hydration error
alexvuong May 5, 2023
6c5df47
fix form, and bump testing-library/user-event
alexvuong May 5, 2023
69f50de
Merge branch 'v3' into upgrade-react-18
alexvuong May 5, 2023
127f52e
linting
alexvuong May 5, 2023
19cf108
remove unused packages
alexvuong May 6, 2023
980582e
clean up
alexvuong May 8, 2023
e9fb9b5
fix tests
alexvuong May 8, 2023
98ecdc8
fix tests
alexvuong May 9, 2023
764f52f
fix ts
alexvuong May 9, 2023
2417f95
regenerate lock files
alexvuong May 9, 2023
29ab6ad
clean up
alexvuong May 9, 2023
a9b6787
fix tests, and enforce npm 8
alexvuong May 10, 2023
ee23020
fix tests
alexvuong May 10, 2023
75a4050
fix tests
alexvuong May 10, 2023
3a1bb2e
update engines to npm 8
alexvuong May 10, 2023
2a09e1a
drop 7 on CI
alexvuong May 10, 2023
44cba91
minor fix
alexvuong May 10, 2023
ec2dae3
Merge branch 'v3' into upgrade-react-18
alexvuong May 10, 2023
ecd0283
fiz tests, drop npm 7
alexvuong May 10, 2023
dc66133
clean up
alexvuong May 10, 2023
c466ce6
fix tests
alexvuong May 10, 2023
17c12d8
PR feedback
alexvuong May 10, 2023
0839ff4
Merge branch 'v3' into upgrade-react-18
alexvuong May 10, 2023
18c8794
gen lock file again
alexvuong May 10, 2023
bd4881d
drop npm7 in CI for windows
alexvuong May 10, 2023
9eb5ff9
minor fix
alexvuong May 10, 2023
668b8eb
regen lock file again!
alexvuong May 10, 2023
731e40c
minor fix
alexvuong May 11, 2023
209a8a0
lint
alexvuong May 11, 2023
6f8564d
swap element order to avoid hydration error
alexvuong May 11, 2023
5616bea
do user setup in renderWithProviders
alexvuong May 11, 2023
29c6b1d
Footer: remove `isHydrated` call
vmarta May 11, 2023
a6109af
update lock files
alexvuong May 12, 2023
b914667
fix: update commerce-sdk-react unit tests to work with react 18 (#1184)
joeluong-sfcc May 12, 2023
c6532ad
Merge branch 'develop' into upgrade-react-18
alexvuong May 12, 2023
0c7e541
update from new develop and gen lock files
alexvuong May 12, 2023
d5e4b4b
update React in test project
alexvuong May 15, 2023
673860e
update React in test project
alexvuong May 15, 2023
2f4862e
Merge branch 'develop' into upgrade-react-18
alexvuong May 15, 2023
32c7c0f
needs to use override for nwsapi in Retail app
alexvuong May 15, 2023
4b4667f
update lock files
alexvuong May 15, 2023
b18c75c
Replace enzyme (#1201)
alexvuong May 15, 2023
2f69f6a
address feedback
alexvuong May 15, 2023
c619baa
clean up
alexvuong May 15, 2023
6ab7ac2
clean up
alexvuong May 15, 2023
63d5656
clean up
alexvuong May 15, 2023
047201e
address feedback
alexvuong May 15, 2023
f149f3c
update the doc and changelog
alexvuong May 15, 2023
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
lint
alexvuong committed May 11, 2023
commit 209a8a072cef98e1a0ad90d87972e315c44490af
Original file line number Diff line number Diff line change
@@ -264,7 +264,11 @@ function UseCustomer() {
>
loginRegisteredUser
</button>
{loginError && <p style={{color: 'red'}}>Error: {loginErrorMessage}</p>}
{loginError && (
<p style={{color: 'red'}}>
<>Error: {loginErrorMessage}</>
</p>
)}
</>
) : (
<>