[V3][Hooks Integration 🪝] Replace last of the getProps
#1149
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for the contribution! It looks like @vmarta @kevinxh is an internal user so signing the CLA is not required. However, we need to confirm this. |
|
Thanks for the contribution! Before we can merge this, we need @vcua-mobify @bendvc @yunakim714 to sign the Salesforce Inc. Contributor License Agreement. |
alexvuong
reviewed
Apr 24, 2023
packages/template-retail-react-app/app/components/_app/index.jsx
Outdated
Show resolved
Hide resolved
alexvuong
approved these changes
Apr 25, 2023
kevinxh
reviewed
Apr 25, 2023
kevinxh
approved these changes
Apr 25, 2023
kevinxh
reviewed
Apr 25, 2023
|
|
||
| const hocs = AppConfig.getHOCsInUse() | ||
| const getPropsEnabled = hocs.indexOf(withLegacyGetProps) >= 0 | ||
|
|
||
| const extraArgs = getPropsEnabled ? AppConfig.extraGetPropsArgs(locals) : {} |
There was a problem hiding this comment.
what happens if getPropsEnabled is true but extraGetPropsArgs is not defined? Is there a default noop implementation for AppConfig.extraGetPropsArgs ? If not, maybe we should guard undefined extraGetPropsArgs?
bfeister
added a commit
that referenced
this pull request
Apr 28, 2023
…xtensibility-algo-refactor * feature/template-extensibility: split ssr build on local (#1155) (#1156) [V3] Update Page Designer (#1128) bring back deleted package lockfiles fix bad merge conflict [V3][Hooks Integration 🪝] Replace last of the `getProps` (#1149) Fix Page Designer ImageWithText Link component (#1092) # Conflicts: # packages/internal-lib-build/package-lock.json # packages/pwa-kit-create-app/package-lock.json # packages/template-express-minimal/package-lock.json # packages/template-mrt-reference-app/package-lock.json # packages/template-retail-react-app/app/components/_app-config/index.jsx # packages/template-retail-react-app/app/components/_app/index.jsx # packages/template-retail-react-app/app/page-designer/core/component/index.jsx # packages/template-retail-react-app/app/page-designer/core/component/index.test.js # packages/template-retail-react-app/app/page-designer/core/page/index.jsx # packages/template-retail-react-app/app/page-designer/core/page/index.test.js # packages/template-retail-react-app/app/page-designer/core/region/index.jsx # packages/template-retail-react-app/app/page-designer/core/region/index.test.js # packages/template-retail-react-app/app/page-designer/layouts/carousel/index.jsx # packages/template-retail-react-app/app/page-designer/layouts/mobileGrid1r1c/index.jsx # packages/template-retail-react-app/app/page-designer/layouts/mobileGrid2r1c/index.jsx # packages/template-retail-react-app/app/page-designer/layouts/mobileGrid2r2c/index.jsx # packages/template-retail-react-app/app/page-designer/layouts/mobileGrid2r3c/index.jsx # packages/template-retail-react-app/app/page-designer/layouts/mobileGrid3r1c/index.jsx # packages/template-retail-react-app/app/page-designer/layouts/mobileGrid3r2c/index.jsx # packages/template-retail-react-app/app/pages/page-not-found/index.jsx # packages/template-retail-react-app/app/utils/test-utils.js # packages/template-typescript-minimal/package-lock.json # packages/test-commerce-sdk-react/package-lock.json
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
There were a few places left in the
retail-react-templatewhere we were still usinggetProps. A) in thepge-not-foundpage and B) in the_appcomponent. In this PR I'm replacing those uses ofgetPropswith their non-getPropsreact-queryequivalent.NOTE: Because we use ssrPrepass to get hooks working server-side there was an issue where during prepass the messages aren't available, leading to warnings in the console for missing translations. To work around this I updated the custom error handler to only warn if there are messages defined/loaded and the individual message isn't found.
Types of Changes
Changes
withLegacyGetPropsHOCextraGetPropsArgsimplementation even when you aren't using getProps.getPropsHOC from test render function.How to Test-Drive This PR
Checklists
General