Add multi-value param bug fix/work around in SDK
#1134
Conversation
bendvc
changed the title
multi-value param bug fix/work around in SDKmulti-value param bug fix/work around in SDK
| @@ -73,6 +73,29 @@ const logAndFormatError = (err) => { | |||
| } | |||
| } | |||
|
|
|||
| // Because multi-value params are not supported in `aws-serverless-express` we need to re-add | |||
| // the stripped duplicate params. | |||
| const FIX_LOCATION_SEARCH = (req, location) => { | |||
There was a problem hiding this comment.
Lol 😆 same as @alexvuong ... Caps is for constants... I would name it fixMePleaseLocationSearch
There was a problem hiding this comment.
I did this intentionally to make it super visible. Doing this will ensure that we remove it once we upgrade the underlying library.
| @@ -94,11 +117,15 @@ export const render = async (req, res, next) => { | |||
| const WrappedApp = routeComponent(App, false, res.locals) | |||
|
|
|||
| const [pathname, search] = req.originalUrl.split('?') | |||
| const location = { | |||
| let location = { | |||
There was a problem hiding this comment.
We are changing property inside the location object, const is still valid
There was a problem hiding this comment.
Artifact of going to different solution iterations. Fixed it.
There was a problem hiding this comment.
Agree with @alexvuong's nits, but not blocking. Thanks for fixing @bendvc! 🙏
|
Closing because when v3 is released the new version of serverless-express will be used an should fix this issue. Here is the PR for v2 |
Description
We are losing multi-value param values in the runtime because of
aws-serverless-expressas a result of thereq.originalUrlnot being fully preserved. For example a request forhostname.com/path?param=1¶m=2will eventually be made available in the SDK and down into the PWA-Kit app with only the last param valuehostname.com/path?param=2.Fortunately this issue doesn't happen to effect the
req.queryproperty. So as a temporary fix, we'll re-create thelocation.searchvalue using thereq.querypaying special attention to the order of the params.This fix is meant to be ugly so we remove it in the future!
Types of Changes
Changes
location.searchproperty in the react rendering pipeline using thereq.paramswhich has the duplicate param values.How to Test-Drive This PR
General