[Retail-app]Add mergeBasket hook #1114
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alexvuong
commented
Apr 6, 2023
packages/template-retail-react-app/app/components/_app/index.jsx
Outdated
Show resolved
Hide resolved
alexvuong
commented
Apr 6, 2023
packages/template-retail-react-app/app/components/_app/index.jsx
Outdated
Show resolved
Hide resolved
kevinxh
reviewed
Apr 6, 2023
packages/template-retail-react-app/app/components/_app/index.jsx
Outdated
Show resolved
Hide resolved
wjhsf
reviewed
Apr 6, 2023
packages/template-retail-react-app/app/components/_app/index.jsx
Outdated
Show resolved
Hide resolved
packages/template-retail-react-app/app/components/_app/index.jsx
Outdated
Show resolved
Hide resolved
… feat/add-merge-basket-hook
bfeister
reviewed
Apr 6, 2023
packages/template-retail-react-app/app/components/_app/index.jsx
Outdated
Show resolved
Hide resolved
kevinxh
reviewed
Apr 6, 2023
packages/template-retail-react-app/app/components/_app/index.jsx
Outdated
Show resolved
Hide resolved
kevinxh
reviewed
Apr 6, 2023
kevinxh
reviewed
Apr 6, 2023
vmarta
reviewed
Apr 10, 2023
vmarta
reviewed
Apr 10, 2023
packages/template-retail-react-app/app/components/_app/index.jsx
Outdated
Show resolved
Hide resolved
packages/template-retail-react-app/app/hooks/use-merge-basket.js
Outdated
Show resolved
Hide resolved
|
After having a chat with @vmarta, it does not make much sense to break the merge logic into a separate hook because there is no context to tell if a user is a recurring user or not, the logic has to stay inside the logic mutation because it provides a hidden context that only recurring users call this mutation, a new user will call register mutation instead. However, this will ended having duplication in useAuthModal, and login page. |
kevinxh
approved these changes
Apr 11, 2023
vmarta
approved these changes
Apr 11, 2023
bfeister
added a commit
that referenced
this pull request
Apr 25, 2023
* v3: [Spike]Replace watch with nodemon (#1146) Fix Page Designer ImageWithText Link component (#1092) (#1148) Upgrade deprecated dependencies (#1124) Restart login flow if refresh_token is invalid (#1135) Move some util to site-utils to avoid circular imports (#1133) Restore old file name. (#1140) Update eslint configuration (#1129) CI: clarify the environment variables (#1127) Remove react-query-devtools from production build (#1121) Update lerna.json (#1118) Parallelize lighthouse ci (#1126) Increase test timeouts only on CI env (#1123) Remove unused `request` deprecated dependency. (#1125) Upgrade msw to latest (#1100) Add mergeBasket hook (#1114) [V3][Hooks Integration 🪝] Manually update cache for ShopperCustomer (#1113) dont use callback on mutateAsync (#1119) 2-spaces not 4-spaces (#1117) # Conflicts: # packages/internal-lib-build/package-lock.json # packages/pwa-kit-create-app/package-lock.json # packages/pwa-kit-dev/package-lock.json # packages/pwa-kit-dev/package.json # packages/pwa-kit-dev/src/configs/webpack/config.js # packages/pwa-kit-dev/src/ssr/server/build-dev-server.js # packages/pwa-kit-react-sdk/package-lock.json # packages/pwa-kit-runtime/package-lock.json # packages/template-express-minimal/package-lock.json # packages/template-mrt-reference-app/package-lock.json # packages/template-retail-react-app/package-lock.json # packages/template-typescript-minimal/package-lock.json # packages/test-commerce-sdk-react/package-lock.json
bfeister
added a commit
that referenced
this pull request
Apr 25, 2023
…-rehaul * feature/template-extensibility: [Spike]Replace watch with nodemon (#1146) Fix Page Designer ImageWithText Link component (#1092) (#1148) Upgrade deprecated dependencies (#1124) Restart login flow if refresh_token is invalid (#1135) Move some util to site-utils to avoid circular imports (#1133) Restore old file name. (#1140) Update eslint configuration (#1129) CI: clarify the environment variables (#1127) Remove react-query-devtools from production build (#1121) Update lerna.json (#1118) Parallelize lighthouse ci (#1126) Increase test timeouts only on CI env (#1123) Remove unused `request` deprecated dependency. (#1125) Upgrade msw to latest (#1100) Add mergeBasket hook (#1114) [V3][Hooks Integration 🪝] Manually update cache for ShopperCustomer (#1113) dont use callback on mutateAsync (#1119) 2-spaces not 4-spaces (#1117) # Conflicts: # packages/internal-lib-build/package-lock.json # packages/pwa-kit-dev/package-lock.json # packages/pwa-kit-react-sdk/package-lock.json # packages/pwa-kit-runtime/package-lock.json # packages/pwa-kit-runtime/package.json
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Types of Changes
Changes
How to Test-Drive This PR
Checklists
General
Accessibility Compliance
You must check off all items in one of the follow two lists:
or...
Localization