-
Notifications
You must be signed in to change notification settings - Fork 146
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix circular imports. #1091
Fix circular imports. #1091
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can we get a description of what this is doing? Specifically, did this manifest as an error? If yes, how and where?
This is just moving function definitions to avoid circular imports. It's just to make the imports cleaner, there aren't currently any errors. |
* @param {string} url | ||
* @returns {object} site - a site object | ||
*/ | ||
export const resolveSiteFromUrl = (url) => { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
a bit of context: reason we put this func and resolvePathFromUrl is to have all the multi-site util in one single file
@@ -1,13 +1,14 @@ | |||
/* |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The functions in this file is to process the given url and return a new one while resolveSiteFromUrl
and resolveLocaleFromUrl
is the other way around which it looks into the given url, extract and return data. I don't think they belong here 🤔
Replaced by #1133. |
Description
Types of Changes
Changes
How to Test-Drive This PR
Checklists
General
Accessibility Compliance
You must check off all items in one of the follow two lists:
or...
Localization