Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BUG] Support multivalue query parameters #733

Closed
johnboxall opened this issue Sep 22, 2022 · 3 comments
Closed

[BUG] Support multivalue query parameters #733

johnboxall opened this issue Sep 22, 2022 · 3 comments
Labels
Acknowledged Team has responded to issue
Milestone

Comments

@johnboxall
Copy link
Collaborator

johnboxall commented Sep 22, 2022

URLs may contain multivalue query parameters. That is a parameter with the same name may appear multiple times in a query string: ?q=123&q=abc.

As an example, SCAPI's product search API allows you to use the refine parameter multiple times to set a number of refinements on a search.

Today, multiple values are discarded and only the last value is available on Express code.

This is because the version of aws-serverless-express we're using doesn't correct forward the Lambda event to the Express server: CodeGenieApp/serverless-express#214

This issue only impacts code running on Managed Runtime, it doesn't appear locally, because we don't use the lib locally.

@bendvc
Copy link
Collaborator

bendvc commented Jan 25, 2023

Hey @johnboxall thank you for supporting the community, we've discussed this with the PM and we are looking to get this in to the next major version release. @natemarcus

@bendvc bendvc added the Acknowledged Team has responded to issue label Jan 25, 2023
@bfeister
Copy link
Collaborator

bfeister commented Apr 4, 2023

I've created a new bug for this unintentionally, but a customer is tracking the new one so we might close this as dupe... or just keep both ope

#1106

@bfeister bfeister added this to the v3 milestone Apr 4, 2023
@bfeister
Copy link
Collaborator

#1106 Fixes this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Acknowledged Team has responded to issue
Projects
None yet
Development

No branches or pull requests

3 participants