Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BUG] Multi-Value Query Params Do not Pass Through pwa-kit-runtime SDK #1106

Closed
bfeister opened this issue Apr 4, 2023 · 2 comments
Closed
Assignees
Labels
Acknowledged Team has responded to issue
Milestone

Comments

@bfeister
Copy link
Collaborator

bfeister commented Apr 4, 2023

Summary

(This bug was initially reported internally and did not have a public issue on github. I'm creating one now for a customer to track the status in a public way)

In PWA Kit, If multiple query parameters exist for the same key, only one is respected.

Steps To Reproduce

  1. Visit https://pwa-kit.mobify-storefront.com/global/en-GB/category/womens-accessories-shoes?limit=25&refine=c_refinementColor%3DBlack&refine=c_size%3D7&refine=price%3D%2850..100%29&sort=best-matches
  2. Observe that only the price=50..100 filter is active, while the color=black and size=7 (both sub-keys under the parent refine key) should be active, they are not.

Expected result

Duplicate query param keys for refine should all be selected (in the example above color=black, size=7 and price=50..100 should all be selected)

Actual result

only the price=50..100 filter is active, while the color=black and size=7 (both sub-keys under the parent refine key) should be active, they are not.

System Information (as applicable)

Browser:
Node version:
pwa-kit version:
Desktop OS:
Mobile Device Info:

Additional information

Feel free to attach a screenshot.

@bfeister bfeister self-assigned this Apr 4, 2023
@bfeister bfeister added this to the v3 milestone Apr 4, 2023
@bfeister bfeister changed the title [BUG] Multi-Value Query Params Do not Pass Through `pwa-kit-runtime SDK [BUG] Multi-Value Query Params Do not Pass Through pwa-kit-runtime SDK Apr 4, 2023
@bfeister
Copy link
Collaborator Author

bfeister commented Apr 4, 2023

Internally, this is an existing open bug in GUS - https://gus.lightning.force.com/lightning/r/ADM_Work__c/a07EE00001LAbqRYAT/view

@bfeister bfeister added the Acknowledged Team has responded to issue label Apr 4, 2023
@vcua-mobify
Copy link
Contributor

This is fixed in release 2.7.1

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Acknowledged Team has responded to issue
Projects
None yet
Development

No branches or pull requests

2 participants