fixing failing test, added tests for removeSiteLocaleFromPath

SalesforceCommerceCloud · Mar 23, 2023 · f8f4504 · alexvuong · Mar 23, 2023 · sandragolden
1 parent c8a3ff6
commit f8f4504
Show file tree

Hide file tree

Showing 3 changed files with 35 additions and 4 deletions.
diff --git a/packages/template-retail-react-app/app/pages/checkout/confirmation.test.js b/packages/template-retail-react-app/app/pages/checkout/confirmation.test.js
@@ -26,6 +26,14 @@ jest.mock('../../commerce-api/auth', () => {
     }
 })
 
+jest.mock('../../utils/url', () => {
+    const original = jest.requireActual('../../utils/url')
+    return {
+        ...original,
+        removeSiteLocaleFromPath: jest.fn(() => original.removeSiteLocaleFromPath)
+    }
+})
+
 const mockOrder = keysToCamel({
     basket_id: 'testorderbasket',
     ...ocapiOrderResponse

diff --git a/packages/template-retail-react-app/app/utils/url.js b/packages/template-retail-react-app/app/utils/url.js
@@ -272,15 +272,15 @@ export const removeQueryParamsFromPath = (path, keys) => {
  * // returns '/account/wishlist'
  */
 export const removeSiteLocaleFromPath = (pathName = '') => {
-    let {siteRef, localeRef} = getParamsFromPath(`${pathName}`)
+    let {siteRef, localeRef} = getParamsFromPath(pathName)
 
     // remove the site alias from the current pathName
     if (siteRef) {
-        pathName = pathName.replace(`/${siteRef}`, '')
+        pathName = pathName.replace(new RegExp(`/${siteRef}`, 'g'), '')
     }
     // remove the locale from the current pathName
     if (localeRef) {
-        pathName = pathName.replace(`/${localeRef}`, '')
+        pathName = pathName.replace(new RegExp(`/${localeRef}`, 'g'), '')
     }
 
     return pathName

diff --git a/packages/template-retail-react-app/app/utils/url.test.js b/packages/template-retail-react-app/app/utils/url.test.js
@@ -14,7 +14,8 @@ import {
     rebuildPathWithParams,
     removeQueryParamsFromPath,
     absoluteUrl,
-    createUrlTemplate
+    createUrlTemplate,
+    removeSiteLocaleFromPath
 } from './url'
 import {getUrlConfig} from './utils'
 import mockConfig from '../../config/mocks/default'
@@ -389,3 +390,25 @@ describe('absoluteUrl', function () {
         expect(url).toEqual('https://www.example.com/uk/en/women/dresses')
     })
 })
+
+describe('removeSiteLocaleFromPath', function () {
+    test('return path without site alias and locale', () => {
+        const pathName = removeSiteLocaleFromPath('/uk/en-GB/account/wishlist')
+        expect(pathName).toEqual('/account/wishlist')
+    })
+
+    test('return path without site alias if they appear multiple times', () => {
+        const pathName = removeSiteLocaleFromPath('/uk/en-GB/uk/en-GB/account/wishlist')
+        expect(pathName).toEqual('/account/wishlist')
+    })
+
+    test('return expected path name when no locale or site alias appear', () => {
+        const pathName = removeSiteLocaleFromPath('/account/wishlist')
+        expect(pathName).toEqual('/account/wishlist')
+    })
+
+    test('return empty string when no path name is passed', () => {
+        const pathName = removeSiteLocaleFromPath()
+        expect(pathName).toEqual('')
+    })
+})