Skip to content

Commit

Permalink
Merge branch 'feature/template-extensibility' into feature/template-e…
Browse files Browse the repository at this point in the history
…xtensibility-algo-refactor + regen lockfiles

* feature/template-extensibility:
  regen package lockfiles
  fix: remove device-context and detect-device-type (#1168)
  Dependency updates (#1170)
  [Snyk] Security upgrade cosmiconfig from 7.1.0 to 8.0.0 (#1145)
  [V3] Remove `cross-fetch` from `template-retail-react-app` (#1160)
  [v3] Add suffix to ssr build files (#1158)
  Consume new version of the commerce-sdk-isomorphic to enable Phased Launches support HTTP Basic Auth (#1153)

# Conflicts:
#	package-lock.json
#	packages/commerce-sdk-react/package-lock.json
#	packages/internal-lib-build/package-lock.json
#	packages/my-extended-retail-app/package-lock.json
#	packages/pwa-kit-create-app/package-lock.json
#	packages/pwa-kit-dev/package-lock.json
#	packages/pwa-kit-react-sdk/package-lock.json
#	packages/pwa-kit-runtime/package-lock.json
#	packages/template-retail-react-app/app/hooks/use-einstein.test.js
#	packages/template-retail-react-app/package-lock.json
#	packages/template-typescript-minimal/package-lock.json
#	packages/test-commerce-sdk-react/package-lock.json
  • Loading branch information
bfeister committed May 9, 2023
2 parents 2afa605 + 2c6be38 commit de5fd5c
Show file tree
Hide file tree
Showing 30 changed files with 1,454 additions and 2,616 deletions.
2,075 changes: 601 additions & 1,474 deletions package-lock.json

Large diffs are not rendered by default.

38 changes: 19 additions & 19 deletions packages/commerce-sdk-react/package-lock.json

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

2 changes: 1 addition & 1 deletion packages/commerce-sdk-react/package.json
Original file line number Diff line number Diff line change
Expand Up @@ -40,7 +40,7 @@
"version": "node ./scripts/version.js"
},
"dependencies": {
"commerce-sdk-isomorphic": "^1.9.0",
"commerce-sdk-isomorphic": "^1.10.1",
"js-cookie": "^3.0.1",
"jwt-decode": "^3.1.2"
},
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -16,7 +16,13 @@ describe('Shopper Baskets hooks', () => {
const unimplemented = getUnimplementedEndpoints(ShopperBaskets, queries, mutations)
// If this test fails: create a new query hook, add the endpoint to the mutations enum,
// or add it to the `expected` array with a comment explaining "TODO" or "never" (and why).
expect(unimplemented).toEqual([])
expect(unimplemented).toEqual([
'updateAsAgentBasket', //TODO: implement later
'addPriceAdjustmentToBasket', //TODO: implement later
'removePriceAdjustmentFromBasket', //TODO: implement later
'updatePriceAdjustmentInBasket', //TODO: implement later
'updateAsStorefrontBasket' //TODO: implement later
])
})
test('all mutations have cache update logic', () => {
// unimplemented = value in mutations enum, but no method in cache update matrix
Expand Down
2 changes: 1 addition & 1 deletion packages/commerce-sdk-react/src/test-utils.tsx
Original file line number Diff line number Diff line change
Expand Up @@ -159,7 +159,7 @@ const getQueryName = (method: string): string => {
* Gets the list of API endpoints that have not yet been implemented
* @param SdkClass Class constructor from commerce-sdk-isomorphic to use as a source for endpoints
* @param queryHooks Object containing implemented query hooks
* @param mutationsEnum Enum containing mutation endpoint names
* @param mutations Enum containing mutation endpoint names
* @returns List of endpoints that don't have a query or mutation hook
*/
export const getUnimplementedEndpoints = (
Expand Down
88 changes: 44 additions & 44 deletions packages/internal-lib-build/package-lock.json

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

Loading

0 comments on commit de5fd5c

Please sign in to comment.